Skip to content

Use semantic dropdown for code search query type#15276

Merged
techknowlogick merged 2 commits into
go-gitea:masterfrom
CL-Jeremy:repo-search-semantic-dropdown
Apr 9, 2021
Merged

Use semantic dropdown for code search query type#15276
techknowlogick merged 2 commits into
go-gitea:masterfrom
CL-Jeremy:repo-search-semantic-dropdown

Conversation

@CL-Jeremy
Copy link
Copy Markdown
Contributor

@CL-Jeremy CL-Jeremy commented Apr 4, 2021

Reference: #15208 (comment)

Explore > code search:
Bildschirmfoto von 2021-04-04 17-04-46

Repo search:
Bildschirmfoto von 2021-04-04 17-04-52

Plus converting spaces to tabs for templates/explore/code.tmpl

@CL-Jeremy
Copy link
Copy Markdown
Contributor Author

CL-Jeremy commented Apr 4, 2021

I don't see anything inherently wrong in it besides the arrow being a bit ugly but using it over a dropdown has accessibilty benefits.

I actually followed the thread on the accessibility issue (#7057) and was thinking about making this a toggle-style input (horizontal menu), but wasn't satisfied with it. In the end I went to favor consistency, leaving this issue for later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 4, 2021
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 4, 2021

This introduces a regression in the code search where the search results are no longer in ui container and they stretch the full width. Please fix.

@CL-Jeremy CL-Jeremy force-pushed the repo-search-semantic-dropdown branch from 97ef20f to b7e7cf2 Compare April 4, 2021 22:12
@CL-Jeremy
Copy link
Copy Markdown
Contributor Author

CL-Jeremy commented Apr 4, 2021

Whoops, had an extra </div> after <button></button>

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 4, 2021

Codecov Report

Merging #15276 (b7e7cf2) into master (487f2ee) will increase coverage by 1.44%.
The diff coverage is 49.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15276      +/-   ##
==========================================
+ Coverage   42.21%   43.65%   +1.44%     
==========================================
  Files         767      671      -96     
  Lines       81624    81007     -617     
==========================================
+ Hits        34458    35366     +908     
+ Misses      41531    39907    -1624     
- Partials     5635     5734      +99
Impacted Files Coverage Δ
cmd/dump.go 0.93% <0.00%> (-0.01%) ⬇️
cmd/serv.go 2.61% <0.00%> (-0.02%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
cmd/web_graceful.go 0.00% <0.00%> (ø)
cmd/web_letsencrypt.go 0.00% <0.00%> (ø)
models/admin.go 60.31% <ø> (ø)
models/commit_status.go 61.74% <0.00%> (ø)
models/consistency.go 36.26% <0.00%> (-16.68%) ⬇️
models/fixture_generation.go 70.00% <ø> (ø)
models/helper_environment.go 93.33% <ø> (ø)
... and 326 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2715b8...b7e7cf2. Read the comment docs.

silverwind
silverwind reviewed Apr 5, 2021
View reviewed changes
Comment thread web_src/less/_base.less Outdated
@silverwind silverwind added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/ui Change the appearance of the Gitea UI and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 7, 2021
@CL-Jeremy CL-Jeremy mentioned this pull request Apr 9, 2021
Merged
@CL-Jeremy CL-Jeremy force-pushed the repo-search-semantic-dropdown branch from 5df1a62 to 041ec62 Compare April 9, 2021 10:49
CL-Jeremy added a commit to CL-Jeremy/gitea that referenced this pull request Apr 9, 2021
@CL-Jeremy
Use semantic dropdown for code search query type (go-gitea#15276)
49f7102
@CL-Jeremy CL-Jeremy mentioned this pull request Apr 9, 2021
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2021
@zeripath zeripath added this to the 1.15.0 milestone Apr 9, 2021
@techknowlogick
Copy link
Copy Markdown
Member

techknowlogick commented Apr 9, 2021

🚀

@techknowlogick techknowlogick merged commit 013657e into go-gitea:master Apr 9, 2021
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 9, 2021
@CL-Jeremy CL-Jeremy deleted the repo-search-semantic-dropdown branch April 9, 2021 20:56
techknowlogick pushed a commit that referenced this pull request Apr 11, 2021
@CL-Jeremy @lunny @6543
Use semantic dropdown for code search query type (#15276) (#15364)
330fa75 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
aswild added a commit to aswild/gitea that referenced this pull request May 3, 2021
@aswild
Merge tag 'v1.14.1' into wild/v1.14
717e81a 
v1.14.1

* BUGFIXES
  * Fix bug clone wiki (go-gitea#15499) (go-gitea#15502)
  * Github Migration ignore rate limit, if not enabled (go-gitea#15490) (go-gitea#15495)
  * Use subdir for URL (go-gitea#15446) (go-gitea#15493)
  * Query the DB for the hash before inserting in to email_hash (go-gitea#15457) (go-gitea#15491)
  * Ensure review dismissal only dismisses the correct review (go-gitea#15477) (go-gitea#15489)
  * Use index of the supported tags to choose user lang (go-gitea#15452) (go-gitea#15488)
  * Fix wrong file link in code search page (go-gitea#15466) (go-gitea#15486)
  * Quick template fix for built-in SSH server in admin config (go-gitea#15464) (go-gitea#15481)
  * Prevent superfluous response.WriteHeader (go-gitea#15456) (go-gitea#15476)
  * Fix ambiguous argument error on tags (go-gitea#15432) (go-gitea#15474)
  * Add created_unix instead of expiry to migration (go-gitea#15458) (go-gitea#15463)
  * Fix repository search (go-gitea#15428) (go-gitea#15442)
  * Prevent NPE on avatar direct rendering if federated avatars disabled (go-gitea#15434) (go-gitea#15439)
  * Fix wiki clone urls (go-gitea#15430) (go-gitea#15431)
  * Fix dingtalk icon url at webhook (go-gitea#15417) (go-gitea#15426)
  * Standardise icon on projects PR page (go-gitea#15387) (go-gitea#15408)
* ENHANCEMENTS
  * Add option to skip LFS/attachment files for `dump` (go-gitea#15407) (go-gitea#15492)
  * Clone panel fixes (go-gitea#15436)
  * Use semantic dropdown for code search query type (go-gitea#15276) (go-gitea#15364)
* BUILD
  * Build go-git variants for windows (go-gitea#15482) (go-gitea#15487)
  * Lock down build-images dependencies (Partial go-gitea#15479) (go-gitea#15480)
* MISC
  * Performance improvement for list pull requests (go-gitea#15447) (go-gitea#15500)
  * Fix potential copy lfs records failure when fork a repository (go-gitea#15441) (go-gitea#15485)
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

6 participants

@CL-Jeremy @silverwind @codecov-io @techknowlogick @zeripath @GiteaBot